This is an archive of the discontinued LLVM Phabricator instance.

[RecoveryExpr] Add 11.0.0 release note.
ClosedPublic

Authored by hokein on Aug 27 2020, 1:37 AM.

Details

Reviewers
sammccall

Diff Detail

Event Timeline

hokein created this revision.Aug 27 2020, 1:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2020, 1:37 AM
hokein requested review of this revision.Aug 27 2020, 1:37 AM
sammccall accepted this revision.Aug 27 2020, 6:02 AM
sammccall added inline comments.
clang/docs/ReleaseNotes.rst
51

nit: AST rather than ASTs (matching the flag, and also it's AST is singular in the text)

81

This feature is on by default for C++ code, and can be explicitly controlled with `-Xclang -f[no-]recovery-ast`.

This revision is now accepted and ready to land.Aug 27 2020, 6:02 AM
tschuett added inline comments.
clang/docs/ReleaseNotes.rst
73

clangd-11 or clang-11?

sammccall added inline comments.Aug 27 2020, 6:18 AM
clang/docs/ReleaseNotes.rst
65

Oops, I missed this, I think this should be three code blocks: one for C++, one for the first AST and one for the second AST.
Tex like "clang-10 produces the minimal placeholder" goes between them rather than in the code blocks.

(I don't think pretending this is all C++ and wrapping it in comments helps readability)

hokein updated this revision to Diff 288543.Aug 28 2020, 12:53 AM
hokein marked 4 inline comments as done.

address comments