Page MenuHomePhabricator

[llvm] [DAG] Fix bug in llvm.get.active.lane.mask lowering
ClosedPublic

Authored by aartbik on Aug 25 2020, 5:58 PM.

Details

Summary

This intrinsic only accepted proper machine vector lengths.
Fixed by this change. With unit tests.

https://bugs.llvm.org/show_bug.cgi?id=47299

Diff Detail

Event Timeline

aartbik created this revision.Aug 25 2020, 5:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2020, 5:58 PM
aartbik requested review of this revision.Aug 25 2020, 5:58 PM
aartbik edited the summary of this revision. (Show Details)Aug 25 2020, 6:03 PM
SjoerdMeijer accepted this revision.Aug 26 2020, 1:26 AM

LGTM. Thanks for fixing this.

This revision is now accepted and ready to land.Aug 26 2020, 1:26 AM

One minor addition, this change is now tested for X86, but I thought it wouldn't do any harm to test this for ARM too. If you can and want to touch the ARM backend test, I wouldn't mind if you e.g. add test @create_mask7 to llvm/test/CodeGen/Thumb2/active_lane_mask.ll, otherwise I will just add that once this lands.

Thanks. No problem, I will add the Thumb test in a follow up CL right after this submits (just to spread the risk of breakage).
It will be a good exercise for me to branch out of X86 :-)