Page MenuHomePhabricator

[clangd] Enforce trailing slash for remote index's project root
ClosedPublic

Authored by kbobyrev on Aug 11 2020, 12:57 AM.

Diff Detail

Event Timeline

kbobyrev created this revision.Aug 11 2020, 12:57 AM
kbobyrev requested review of this revision.Aug 11 2020, 12:57 AM
hokein added inline comments.Aug 11 2020, 1:38 AM
clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp
387 ↗(On Diff #284597)

Instead of handling this in all callers, I think it might be better to move it to Marshaller and drop the ends-with-slash assertion there.

kbobyrev updated this revision to Diff 284609.Aug 11 2020, 1:46 AM
kbobyrev marked an inline comment as done.

Handle slash appending in Marshaller.

kbobyrev updated this revision to Diff 284611.Aug 11 2020, 1:47 AM

Remove redundant .str() calls.

hokein accepted this revision.Aug 11 2020, 2:17 AM
This revision is now accepted and ready to land.Aug 11 2020, 2:17 AM
This revision was landed with ongoing or failed builds.Aug 11 2020, 4:25 AM
This revision was automatically updated to reflect the committed changes.