Page MenuHomePhabricator

[Attributor] Fix bug in operator of PotentialValuesState
AbandonedPublic

Authored by okura on Aug 10 2020, 4:55 AM.

Details

Summary

There are bugs in operator &= and operator ^= in PotentialValuesState.
When we clamp states, helper BooleanStates should be but were not clamped.

Diff Detail

Event Timeline

okura created this revision.Aug 10 2020, 4:55 AM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
okura requested review of this revision.Aug 10 2020, 4:55 AM
okura added a comment.Aug 10 2020, 5:44 AM

Test?

In the current situation of AAPotentialValues, I think it is difficult to reflect this change in tests. I noticed this bug when I worked on D85632 and saw affected tests because AAPotentialValues has interface only.
Should I include the changes here in that patch? (But I feel that the patch is big and want to split it if possible.)

IMHO, these few lines don't make much of a difference wrt the size of the patch. Maybe just merge them?

okura abandoned this revision.Aug 10 2020, 6:26 AM

OK, I'll merge this with D85632.