Page MenuHomePhabricator

Add the inline interface to the shape dialect
ClosedPublic

Authored by liufengdb on Aug 7 2020, 2:15 PM.

Details

Summary

This patch also fixes a minor issue that shape.rank should allow
returning !shape.size. The dialect doc has such an example for
shape.rank.

Diff Detail

Event Timeline

liufengdb created this revision.Aug 7 2020, 2:15 PM
Herald added a project: Restricted Project. · View Herald Transcript
liufengdb requested review of this revision.Aug 7 2020, 2:15 PM
liufengdb updated this revision to Diff 284056.Aug 7 2020, 2:16 PM

fix the lint

silvas accepted this revision.Aug 7 2020, 2:55 PM
silvas added inline comments.
mlir/lib/Dialect/Shape/IR/Shape.cpp
672–678

add test.

This revision is now accepted and ready to land.Aug 7 2020, 2:55 PM
liufengdb updated this revision to Diff 284099.Aug 7 2020, 5:18 PM

add a test

liufengdb updated this revision to Diff 284105.Aug 7 2020, 5:39 PM

fix the test error

jpienaar added inline comments.Aug 7 2020, 5:45 PM
mlir/lib/Dialect/Shape/IR/Shape.cpp
68

This doesn't seem related to TFR.

This revision was automatically updated to reflect the committed changes.