Paths
| Differential D85551
[OpenMP] Split OpenMP/target_map_codegen test [NFC] ClosedPublic Authored by tra on Aug 7 2020, 1:14 PM.
Details Summary The test file is the single longest test among clang's tests and ends up about The test appears to consist of multiple independent subtests and does not have See before/after comparison here:
Diff Detail
Event TimelineComment Actions Wow, cool. I imagine it was hard to split this given the manual check lines. We really need to start using the upgrade scripts here. I'm fine with this, @ABataev WDYT? Comment Actions
It was not that hard. The file had pretty uniform structure, so all it took is trivial edit to add // CK to #endif lines of individual sections and the following two commands did the rest: csplit -f './test/OpenMP/target_map_codegen_' -b '%02d.cp' ./test/OpenMP/target_map_codegen.cpp '/#endif \/\/\ CK/1' '{*}'
for f in ./test/OpenMP/target_map_codegen_*.cp; do (head -4 ./test/OpenMP/target_map_codegen.cpp; cat $f; echo '#endif') > ${f}p; doneComment Actions
Very cool. Thanks for sharing this!
This revision is now accepted and ready to land.Aug 7 2020, 1:36 PM
This revision was landed with ongoing or failed builds.Aug 7 2020, 1:48 PM Closed by commit rGcd01980f308a: [OpenMP] Split OpenMP/target_map_codegen test [NFC] (authored by tra). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 284038 clang/test/OpenMP/target_map_codegen.cpp
clang/test/OpenMP/target_map_codegen_00.cpp
clang/test/OpenMP/target_map_codegen_01.cpp
clang/test/OpenMP/target_map_codegen_02.cpp
clang/test/OpenMP/target_map_codegen_03.cpp
clang/test/OpenMP/target_map_codegen_04.cpp
clang/test/OpenMP/target_map_codegen_05.cpp
clang/test/OpenMP/target_map_codegen_06.cpp
clang/test/OpenMP/target_map_codegen_07.cpp
clang/test/OpenMP/target_map_codegen_08.cpp
clang/test/OpenMP/target_map_codegen_09.cpp
clang/test/OpenMP/target_map_codegen_10.cpp
clang/test/OpenMP/target_map_codegen_11.cpp
clang/test/OpenMP/target_map_codegen_12.cpp
clang/test/OpenMP/target_map_codegen_13.cpp
clang/test/OpenMP/target_map_codegen_14.cpp
clang/test/OpenMP/target_map_codegen_15.cpp
clang/test/OpenMP/target_map_codegen_16.cpp
clang/test/OpenMP/target_map_codegen_17.cpp
clang/test/OpenMP/target_map_codegen_18.cpp
clang/test/OpenMP/target_map_codegen_19.cpp
clang/test/OpenMP/target_map_codegen_20.cpp
clang/test/OpenMP/target_map_codegen_21.cpp
clang/test/OpenMP/target_map_codegen_22.cpp
clang/test/OpenMP/target_map_codegen_23.cpp
clang/test/OpenMP/target_map_codegen_24.cpp
clang/test/OpenMP/target_map_codegen_25.cpp
clang/test/OpenMP/target_map_codegen_26.cpp
clang/test/OpenMP/target_map_codegen_27.cpp
clang/test/OpenMP/target_map_codegen_28.cpp
clang/test/OpenMP/target_map_codegen_29.cpp
clang/test/OpenMP/target_map_codegen_30.cpp
clang/test/OpenMP/target_map_codegen_31.cpp
clang/test/OpenMP/target_map_codegen_32.cpp
clang/test/OpenMP/target_map_codegen_33.cpp
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file is still among the longest tests in clang and could use some further splitting, if possible.
Between this and arm-cortex-cpus.c tests there are another 10 seconds we could shave off the test time.