This is an archive of the discontinued LLVM Phabricator instance.

Differential D85465

[flang] Remove extra CMAKE_CXX_FLAGS in Lower and Optimizer
ClosedPublic

Authored by tskeith on Aug 6 2020, 12:13 PM.

Details

Reviewers
klausler
PeteSteinfeld
schweitz
sscalpone
jdoerfert
DavidTruby
Commits
rGcf03bcf92922: [flang] Remove extra CMAKE_CXX_FLAGS in Lower and Optimizer
Summary

-Wno-error and -Wno-unused-parameter appear to no longer be needed
for Lower and Optimizer.

Diff Detail

Event Timeline

tskeith created this revision.Aug 6 2020, 12:13 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 6 2020, 12:13 PM
Herald added a reviewer: DavidTruby. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
tskeith requested review of this revision.Aug 6 2020, 12:13 PM
tskeith mentioned this in D85355: [flang][msvc] Do not use gcc/clang command line options for msvc..Aug 6 2020, 12:14 PM
Harbormaster completed remote builds in B67362: Diff 283700.Aug 6 2020, 12:20 PM
Meinersbur added a subscriber: Meinersbur.Aug 6 2020, 1:48 PM

Independently on whether it is decided whether these lines are needed at all, I commited D85355. Hence this will need a rebase (which should be trivial: just remove the added lines as well).

tskeith updated this revision to Diff 283736.Aug 6 2020, 2:24 PM

Rebase

Harbormaster completed remote builds in B67375: Diff 283736.Aug 6 2020, 2:32 PM
PeteSteinfeld accepted this revision.Aug 6 2020, 8:16 PM

All builds, tests, and looks good to me.

This revision is now accepted and ready to land.Aug 6 2020, 8:16 PM
schweitz accepted this revision.Aug 7 2020, 10:13 AM
This revision was landed with ongoing or failed builds.Aug 7 2020, 10:22 AM
Closed by commit rGcf03bcf92922: [flang] Remove extra CMAKE_CXX_FLAGS in Lower and Optimizer (authored by tskeith). · Explain Why
This revision was automatically updated to reflect the committed changes.
tskeith added a commit: rGcf03bcf92922: [flang] Remove extra CMAKE_CXX_FLAGS in Lower and Optimizer.

Revision Contents

PathSize
flang/
lib/
Lower/
3 lines
Optimizer/
3 lines

Diff 283944

flang/lib/Lower/CMakeLists.txt

if (LLVM_COMPILER_IS_GCC_COMPATIBLE)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error -Wno-unused-parameter")
endif ()
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
add_flang_library(FortranLower add_flang_library(FortranLower
CharacterExpr.cpp CharacterExpr.cpp
CharacterRuntime.cpp CharacterRuntime.cpp
Coarray.cpp Coarray.cpp
ComplexExpr.cpp ComplexExpr.cpp
ConvertType.cpp ConvertType.cpp
Show All 29 Lines

flang/lib/Optimizer/CMakeLists.txt

if (LLVM_COMPILER_IS_GCC_COMPATIBLE)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-parameter -Wno-error")
endif ()
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
add_flang_library(FIROptimizer add_flang_library(FIROptimizer
Dialect/FIRAttr.cpp Dialect/FIRAttr.cpp
Dialect/FIRDialect.cpp Dialect/FIRDialect.cpp
Dialect/FIROps.cpp Dialect/FIROps.cpp
Dialect/FIRType.cpp Dialect/FIRType.cpp
Show All 20 Lines