Page MenuHomePhabricator

[clangd] Disable define out-of-line code action on templates
ClosedPublic

Authored by kadircet on Aug 5 2020, 7:22 AM.

Diff Detail

Event Timeline

kadircet created this revision.Aug 5 2020, 7:22 AM
kadircet requested review of this revision.Aug 5 2020, 7:22 AM
hokein added inline comments.Aug 5 2020, 7:57 AM
clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
124–125

since we don't support template functions, I think this code can be removed.

392

is this inner if important? It seems that we could just return false.

kadircet marked 2 inline comments as done.Aug 5 2020, 9:07 AM
kadircet added inline comments.
clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
392

yeah I was considering redeclarations, but they should be handled in the previous if anyways.

kadircet updated this revision to Diff 283266.Aug 5 2020, 9:07 AM
kadircet marked an inline comment as done.
  • Address comments
hokein accepted this revision.Aug 5 2020, 11:01 AM
This revision is now accepted and ready to land.Aug 5 2020, 11:01 AM