Page MenuHomePhabricator

[HotColdSplit] Remove target triples from architecture-agnostic testcases
AbandonedPublic

Authored by hiraditya on Aug 4 2020, 8:53 AM.

Details

Summary

This fixes the build errors on ARM machines ; see relevant discussions in D85148
and D69384.

Diff Detail

Unit TestsFailed

TimeTest
270 mslinux > LLVM.Transforms/HotColdSplit::coldentrycount.ll
Script: -- : 'RUN: at line 4'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -hotcoldsplit -hotcoldsplit-threshold=0 -codegenprepare -S < /mnt/disks/ssd0/agent/llvm-project/llvm/test/Transforms/HotColdSplit/coldentrycount.ll | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/Transforms/HotColdSplit/coldentrycount.ll
130 mswindows > LLVM.Transforms/HotColdSplit::coldentrycount.ll
Script: -- : 'RUN: at line 4'; c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\opt.exe -hotcoldsplit -hotcoldsplit-threshold=0 -codegenprepare -S < C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\Transforms\HotColdSplit\coldentrycount.ll | c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\Transforms\HotColdSplit\coldentrycount.ll

Event Timeline

rjf created this revision.Aug 4 2020, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2020, 8:53 AM
rjf requested review of this revision.Aug 4 2020, 8:53 AM
hiraditya accepted this revision.Aug 4 2020, 8:54 AM

Thanks for fixing it quickly @rjf

This revision is now accepted and ready to land.Aug 4 2020, 8:54 AM
rjf added a comment.Aug 4 2020, 9:38 AM

Looks like coldentrycount.ll is still causing a problem @hiraditya .

In D85215#2193705, @rjf wrote:

Looks like coldentrycount.ll is still causing a problem @hiraditya .

If this is not going to work anytime soon - it would be better to revert the original patch for now.

Should I land D85148 then? I'd like to keep the test case if possible.

hiraditya commandeered this revision.Aug 4 2020, 10:53 AM
hiraditya edited reviewers, added: rjf; removed: hiraditya.
This revision now requires review to proceed.Aug 4 2020, 10:53 AM
hiraditya abandoned this revision.Aug 4 2020, 10:53 AM

will revert the old patch.