diff --git a/clang/lib/Tooling/Tooling.cpp b/clang/lib/Tooling/Tooling.cpp --- a/clang/lib/Tooling/Tooling.cpp +++ b/clang/lib/Tooling/Tooling.cpp @@ -258,7 +258,10 @@ // --driver-mode=X const std::string DriverModeOPT = Table.getOption(driver::options::OPT_driver_mode).getPrefixedName(); - bool AlreadyHasTarget = false; + auto TargetMode = + driver::ToolChain::getTargetAndModeFromProgramName(InvokedAs); + // No need to search for target args if we don't have a mode to insert. + bool AlreadyHasTarget = !TargetMode.TargetIsValid; bool AlreadyHasMode = false; // Skip CommandLine[0]. for (auto Token = ++CommandLine.begin(); Token != CommandLine.end(); @@ -268,12 +271,10 @@ TokenRef.startswith(TargetOPT) || TokenRef.equals(TargetOPTLegacy); AlreadyHasMode |= TokenRef.startswith(DriverModeOPT); } - auto TargetMode = - driver::ToolChain::getTargetAndModeFromProgramName(InvokedAs); if (!AlreadyHasMode && TargetMode.DriverMode) { CommandLine.insert(++CommandLine.begin(), TargetMode.DriverMode); } - if (!AlreadyHasTarget && TargetMode.TargetIsValid) { + if (!AlreadyHasTarget) { CommandLine.insert(++CommandLine.begin(), TargetOPT + TargetMode.TargetPrefix); }