Page MenuHomePhabricator

[NewPM] Don't print 'Invalidating all non-preserved analyses'
ClosedPublic

Authored by aeubanks on Thu, Jul 30, 1:55 PM.

Details

Summary

If an analysis is actually invalidated, there's already a log statement
for that: 'Invalidating analysis: FooAnalysis'.
Otherwise the statement is not very useful.

Diff Detail

Event Timeline

aeubanks created this revision.Thu, Jul 30, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jul 30, 1:55 PM
aeubanks requested review of this revision.Thu, Jul 30, 1:55 PM
nikic added inline comments.Thu, Jul 30, 2:00 PM
llvm/include/llvm/IR/PassManagerImpl.h
131

At this point, does this message still add anything? If this message gets printed, then at least one "Invalidating analysis" message will get printed as well, and that message also includes IR.getName().

aeubanks updated this revision to Diff 282043.Thu, Jul 30, 2:17 PM

Don't print at all

aeubanks retitled this revision from [NewPM] Only print 'Invalidating all ...' when invalidation occurs to [NewPM] Don't print 'Invalidating all non-preserved analyses'.Thu, Jul 30, 2:17 PM
aeubanks edited the summary of this revision. (Show Details)
aeubanks added inline comments.Thu, Jul 30, 2:33 PM
llvm/include/llvm/IR/PassManagerImpl.h
131

Yes you're right. I went ahead and deleted it all.

ychen accepted this revision.Thu, Jul 30, 3:01 PM

It does not reveal more information than 'Invalidating analysis:' and it could show up even if no analyses need to be invalidated for the IR. So LGTM.

This revision is now accepted and ready to land.Thu, Jul 30, 3:01 PM
asbirlea accepted this revision.Thu, Jul 30, 5:51 PM

Thanks for removing the noise.

This revision was landed with ongoing or failed builds.Thu, Jul 30, 7:51 PM
This revision was automatically updated to reflect the committed changes.