Page MenuHomePhabricator

[clang][Syntax] syntax::Arena doesnt own TokenBuffer
ClosedPublic

Authored by kadircet on Jul 30 2020, 12:43 PM.

Details

Summary

Currently an Arena can only be built while consuming a TokenBuffer,
some users (like clangd) might want to share a TokenBuffer with multiple
compenents. This patch changes Arena's TokenBuffer member to be a reference so
that it can be created with read-only token buffers.

Diff Detail

Event Timeline

kadircet created this revision.Jul 30 2020, 12:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2020, 12:43 PM
kadircet requested review of this revision.Jul 30 2020, 12:43 PM
gribozavr2 accepted this revision.Jul 30 2020, 2:07 PM
This revision is now accepted and ready to land.Jul 30 2020, 2:07 PM
This revision was automatically updated to reflect the committed changes.