Page MenuHomePhabricator

[flang][OpenMP] Added initial support for lowering OpenMP parallel construct
ClosedPublic

Authored by SouraVX on Jul 30 2020, 11:33 AM.

Details

Summary

This patch lower !OMP PARALLEL construct from PFT to OpenMPDialect operations.
This is first patch in this direction(lowering parallel construct).

OpenMP parallel construct can have multiple clauses and parameters. This patch
only implements lowering of an empty(contains no code in body) parallel construct
without any clauses or parameters.

Patch is carved out of following approved PR:
https://github.com/flang-compiler/f18-llvm-project/pull/322

Diff Detail

Event Timeline

SouraVX created this revision.Jul 30 2020, 11:33 AM
Herald added a project: Restricted Project. · View Herald Transcript
SouraVX requested review of this revision.Jul 30 2020, 11:33 AM

If this lowers to the OpenMP MLIR Dialect, would it be possible to have some lit codegen tests on the generated IR from a sample input file? Unless not all the necessary infrastructure is in yet for this.

DavidTruby accepted this revision.Jul 31 2020, 5:51 AM

LGTM other than possibly adding a lit test if the right infrastructure is there

This revision is now accepted and ready to land.Jul 31 2020, 5:51 AM

If this lowers to the OpenMP MLIR Dialect, would it be possible to have some lit codegen tests on the generated IR from a sample input file? Unless not all the necessary infrastructure is in yet for this.

We already got this covered, test case is there in PR. Till the bridge code is up-streamed we can't put those sort of test here.