[lldb/Process/Windows] Attempt to kill exited/detached process in not error

[tatyana-krasnukha]

Summary

Don't report an error, just log this happened.
This fixes a lot of "CLEANUP ERROR"s for the test-suite on Windows and makes ProcessWindows consistent with the other processes.

[asmith]

LGTM.

Some changes for grammar to the title -- "[lldb/Process/Windows] Attempting to kill an exited/detached process is not an error"

A little more description would be helpful for others. Here's a suggestion --

"The lldb test-suite on Windows reports a 'CLEANUP ERROR' when attempting to kill an exited/detached process. This change makes ProcessWindows consistent with the other processes which only log the error. After this change a large number of 'CLEANUP ERROR' messages are now removed."

[tatyana-krasnukha]

Thank you! I fixed the commit title and description as you suggested.

lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp

if (!m_session_data) {
       LLDB_LOG(log, "warning: state = {0}, but there is no active session.",
                state);
       return Status();
     }
 
     debugger_thread = m_session_data->m_debugger;
   }
 
-  Status error;
-  if (state != eStateExited && state != eStateDetached) {
-    LLDB_LOG(
-        log, "Shutting down process {0}.",
+  if (state == eStateExited || state == eStateDetached) {
+    LLDB_LOG(log, "warning: cannot destroy process {0} while state = {1}.",
+             GetDebuggedProcessId(), state);
+    return Status();
+  }
+
+  LLDB_LOG(log, "Shutting down process {0}.",
            debugger_thread->GetProcess().GetNativeProcess().GetSystemHandle());
-    error = debugger_thread->StopDebugging(true);
+  auto error = debugger_thread->StopDebugging(true);
 
-    // By the time StopDebugging returns, there is no more debugger thread, so
-    // we can be assured that no other thread will race for the session data.
-    m_session_data.reset();
-  } else {
-    error.SetErrorStringWithFormat("cannot destroy process %" PRIx64
-                                   " while state = %d",
-                                   GetDebuggedProcessId(), state);
-    LLDB_LOG(log, "error: {0}", error);
-  }
+
   return error;
 }
 
 Status ProcessDebugger::HaltProcess(bool &caused_stop) {
   Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS);
   Status error;
   llvm::sys::ScopedLock lock(m_mutex);
   caused_stop = ::DebugBreakProcess(m_session_data->m_debugger->GetProcess()