This is an archive of the discontinued LLVM Phabricator instance.

[NewPM][Attributor] Pin tests with -attributor to legacy PM
ClosedPublic

Authored by aeubanks on Jul 28 2020, 6:00 PM.

Details

Summary

All these tests already explicitly test against both legacy PM and NPM.

$ sed -i 's/ -attributor / -attributor -enable-new-pm=0 /g' $(rg --path-separator -l -- -passes=)
$ sed -i 's/ -attributor-cgscc / -attributor-cgscc -enable-new-pm=0 /g' $(rg --path-separator
-l -- -passes=)

Now all tests in Transforms/Attributor/ pass under NPM.

Diff Detail

Event Timeline

aeubanks created this revision.Jul 28 2020, 6:00 PM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
aeubanks requested review of this revision.Jul 28 2020, 6:00 PM
jdoerfert accepted this revision.Jul 28 2020, 8:25 PM

LGTM, assuming this is NFC and gets us closer to the NPM default :)

This revision is now accepted and ready to land.Jul 28 2020, 8:25 PM