diff --git a/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp b/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp --- a/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp +++ b/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp @@ -21,6 +21,16 @@ } }; +// FIXME: This test seems to cause a strange linking interference +// with the ValidConfiguration.ValidEnumOptions test on macOS. +// If both tests are enabled, this test will fail as if +// runCheckOnCode() is not invoked at all. Looks like a linker bug. +// For now both tests are disabled on macOS. It is not sufficient +// to only disable the other test because this test keeps failing +// under Address Sanitizer, which may be an indication of more +// such linking interference with other tests and this test +// seems to be in the center of it. +#ifndef __APPLE__ TEST(ClangTidyDiagnosticConsumer, SortsErrors) { std::vector Errors; runCheckOnCode("int a;", &Errors); @@ -28,6 +38,7 @@ EXPECT_EQ("type specifier", Errors[0].Message.Message); EXPECT_EQ("variable", Errors[1].Message.Message); } +#endif } // namespace test } // namespace tidy diff --git a/clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp b/clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp --- a/clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp +++ b/clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp @@ -223,6 +223,7 @@ } // FIXME: Figure out why this test causes crashes on mac os. +// See also comments around the ClangTidyDiagnosticConsumer.SortsErrors test. #ifndef __APPLE__ TEST(ValidConfiguration, ValidEnumOptions) {