This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Shape] Limit shape to standard lowerings to their supported types
ClosedPublic

Authored by frgossen on Jul 23 2020, 9:45 AM.

Details

Summary

The lowering does not support all types for its source operations. This change
makes the patterns fail in a well-defined manner.

Depends On D84442

Diff Detail

Event Timeline

frgossen created this revision.Jul 23 2020, 9:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2020, 9:45 AM
pifon2a accepted this revision.Jul 23 2020, 9:51 AM
This revision is now accepted and ready to land.Jul 23 2020, 9:51 AM

Are there any test cases for these new failure cases? If not could you please add some?

herhut accepted this revision.Jul 29 2020, 3:54 AM
frgossen updated this revision to Diff 281559.Jul 29 2020, 6:54 AM

Add tests

This revision was landed with ongoing or failed builds.Jul 29 2020, 6:57 AM
This revision was automatically updated to reflect the committed changes.