This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Set minimum gRPC version to 1.27
AbandonedPublic

Authored by kbobyrev on Jul 21 2020, 4:51 AM.

Details

Reviewers
sammccall
Summary

gRPC 1.26 and earlier are affected by bugs preventing remote index from working:

This patch sets minimum version of gRPC to 1.27 when it is installed manually
or via APT on Debian-like Linux distributions or via Homebrew on macOS.

Related Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965217

Diff Detail

Event Timeline

kbobyrev created this revision.Jul 21 2020, 4:51 AM
kbobyrev updated this revision to Diff 279497.Jul 21 2020, 5:59 AM

Check gRPC version for system-installed APT package on Debian-like Linux
distros.

Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2020, 5:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kbobyrev edited the summary of this revision. (Show Details)Jul 21 2020, 6:00 AM

Aww, this might be problematic. Ubuntu has quite old gRPC versions (which are OK though). The newest is 1.26.0 and it's on Groovy (20.10, unreleased yet).

kbobyrev planned changes to this revision.Jul 24 2020, 1:23 AM

Maybe wait for Debian packages to get updated and then whitelist 1.26.0-4 but fail with anything lower than that.

kbobyrev edited the summary of this revision. (Show Details)Jul 30 2020, 8:45 AM
kbobyrev edited reviewers, added: hokein; removed: sammccall.

This patch is not ready for review yet; planned changes: check if the version is between 1.25.0 and 1.26.0-4 and bail out in such cases.

kbobyrev updated this revision to Diff 299618.Oct 21 2020, 2:59 AM

Rebase on top of master.

kbobyrev updated this revision to Diff 299623.Oct 21 2020, 3:19 AM

Add macOS version check.

kbobyrev edited reviewers, added: sammccall; removed: hokein.Oct 21 2020, 3:21 AM
kbobyrev edited the summary of this revision. (Show Details)

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965217 is not going anywhere, I think we should just add this check and not check for the correct patch on Debian (and macOS is different anyway).

kbobyrev planned changes to this revision.Nov 10 2020, 12:06 AM

Need to exclude everything between 1.26.0 and 1.27.0, not set this as the minimum (Ubuntu packages are outdated).

kbobyrev abandoned this revision.Nov 11 2020, 2:16 AM

There are more revisions that are buggy, can't test them all :(