This is an archive of the discontinued LLVM Phabricator instance.

Differential D83700

Fix test for the hasExternalFormalLinkage matcher
ClosedPublic

Authored by gribozavr on Jul 13 2020, 10:53 AM.

Details

Reviewers
aaron.ballman
rsmith
ymandel
Commits
rG8978032a17cd: Fix test for the hasExternalFormalLinkage matcher
Summary

Names of local variables have no linkage (see C++20 [basic.link] p8).

Names of variables in unnamed namespace have internal linkage (see C++20
[basic.link] p4).

Diff Detail

Event Timeline

gribozavr created this revision.Jul 13 2020, 10:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 10:53 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
gribozavr2 added reviewers: aaron.ballman, rsmith, ymandel.Jul 13 2020, 10:53 AM
Harbormaster failed remote builds in B64002: Diff 277490!Jul 13 2020, 11:06 AM
ymandel accepted this revision.Jul 14 2020, 6:24 AM
This revision is now accepted and ready to land.Jul 14 2020, 6:24 AM
Closed by commit rG8978032a17cd: Fix test for the hasExternalFormalLinkage matcher (authored by gribozavr). · Explain WhyJul 14 2020, 6:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
unittests/
ASTMatchers/
21 lines

Diff 277811

clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp

Show First 20 Lines • Show All 2,528 Lines • ▼ Show 20 Lines struct MyTemplate {
MyTemplate() : field_(__null) {} MyTemplate() : field_(__null) {}
T* field_; T* field_;
}; };
)"; )";
EXPECT_TRUE(matches(kTest, expr(nullPointerConstant()))); EXPECT_TRUE(matches(kTest, expr(nullPointerConstant())));
} }
TEST(HasExternalFormalLinkage, Basic) { TEST(HasExternalFormalLinkage, Basic) {
EXPECT_TRUE(matches("int a = 0;", namedDecl(hasExternalFormalLinkage()))); EXPECT_TRUE(matches("int a = 0;",
EXPECT_TRUE( namedDecl(hasName("a"), hasExternalFormalLinkage())));
notMatches("static int a = 0;", namedDecl(hasExternalFormalLinkage()))); EXPECT_TRUE(notMatches("static int a = 0;",
namedDecl(hasName("a"), hasExternalFormalLinkage())));
EXPECT_TRUE(notMatches("static void f(void) { int a = 0; }", EXPECT_TRUE(notMatches("static void f(void) { int a = 0; }",
namedDecl(hasExternalFormalLinkage()))); namedDecl(hasName("a"), hasExternalFormalLinkage())));
EXPECT_TRUE(matches("void f(void) { int a = 0; }", EXPECT_TRUE(notMatches("void f(void) { int a = 0; }",
namedDecl(hasExternalFormalLinkage()))); namedDecl(hasName("a"), hasExternalFormalLinkage())));
EXPECT_TRUE(notMatches("namespace { int a = 0; }",
// Despite having internal semantic linkage, the anonymous namespace member namedDecl(hasName("a"), hasExternalFormalLinkage())));
// has external linkage because the member has a unique name in all
// translation units.
EXPECT_TRUE(matches("namespace { int a = 0; }",
namedDecl(hasExternalFormalLinkage())));
} }
TEST(HasDefaultArgument, Basic) { TEST(HasDefaultArgument, Basic) {
EXPECT_TRUE( EXPECT_TRUE(
matches("void x(int val = 0) {}", parmVarDecl(hasDefaultArgument()))); matches("void x(int val = 0) {}", parmVarDecl(hasDefaultArgument())));
EXPECT_TRUE( EXPECT_TRUE(
notMatches("void x(int val) {}", parmVarDecl(hasDefaultArgument()))); notMatches("void x(int val) {}", parmVarDecl(hasDefaultArgument())));
} }
▲ Show 20 Lines • Show All 586 Lines • Show Last 20 Lines