This is an archive of the discontinued LLVM Phabricator instance.

[openmp] Remove OMPConstants.cpp and replace it by OMP.cpp generated by tablegen
ClosedPublic

Authored by clementval on Jul 10 2020, 12:30 PM.

Details

Summary

Diff D83176 moved the last piece of code from OMPConstants.cpp and now this file was only
useful to include the tablegen generated file. This patch replace OMPConstants.cpp with OMP.cpp
generated by tablegen.

Diff Detail

Event Timeline

clementval created this revision.Jul 10 2020, 12:30 PM
clementval marked an inline comment as done.Jul 10 2020, 12:48 PM
clementval added inline comments.
llvm/lib/Frontend/OpenMP/CMakeLists.txt
3

The reason to have renamed OMP.cpp.inc to OMP.cpp is that now it is directly source of a library and the name OMP.cpp.inc will be used to generated code pieces that have to be included in clang/flang.

sstefan1 accepted this revision.Jul 10 2020, 3:39 PM

Thanks for figuring this out!

LGTM.

This revision is now accepted and ready to land.Jul 10 2020, 3:39 PM
This revision was automatically updated to reflect the committed changes.
llvm/lib/Frontend/OpenMP/CMakeLists.txt