This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly][NFC] Simplify vector shift lowering and add tests
ClosedPublic

Authored by tlively on Jul 9 2020, 10:16 AM.

Details

Summary

This patch builds on 0d7286a652 by simplifying the code for detecting
splat values and adding new tests demonstrating the lowering of
splatted absolute value shift amounts, which are common in code generated by Halide. The lowering is very bad right
now, but subsequent patches will improve it considerably. The tests
will be useful for evaluating the improvements in those patches.

Diff Detail

Event Timeline

tlively created this revision.Jul 9 2020, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2020, 10:16 AM
aheejin accepted this revision.Jul 9 2020, 2:13 PM
This revision is now accepted and ready to land.Jul 9 2020, 2:13 PM
tlively edited the summary of this revision. (Show Details)Jul 9 2020, 3:28 PM
This revision was automatically updated to reflect the committed changes.