[clang-tidy] Fix an unused-raii check crash on objective-c++.

[gribozavr2]

clang-tools-extra/test/clang-tidy/checkers/bugprone-unused-raii-crash.mm

4

Foo => CxxClass
ABC => ObjcClass

[hokein]

fix names.

clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp

AST_MATCHER(CXXRecordDecl, hasNonTrivialDestructor) {
   return Node.hasDefinition() && Node.hasNonTrivialDestructor();
 }
 } // namespace
 
 void UnusedRaiiCheck::registerMatchers(MatchFinder *Finder) {
   // Look for temporaries that are constructed in-place and immediately
   // destroyed. Look for temporaries created by a functional cast but not for
   // those returned from a call.
-  auto BindTemp =
-      cxxBindTemporaryExpr(unless(has(ignoringParenImpCasts(callExpr()))))
+  auto BindTemp = cxxBindTemporaryExpr(
+                      unless(has(ignoringParenImpCasts(callExpr()))),
+                      unless(has(ignoringParenImpCasts(objcMessageExpr()))))
                       .bind("temp");
   Finder->addMatcher(
       traverse(ast_type_traits::TK_AsIs,
                exprWithCleanups(
                    unless(isInTemplateInstantiation()),
                    hasParent(compoundStmt().bind("compound")),
                    hasType(cxxRecordDecl(hasNonTrivialDestructor())),
                    anyOf(has(ignoringParenImpCasts(BindTemp)),
                          has(ignoringParenImpCasts(cxxFunctionalCastExpr(
if (const auto *TOE = dyn_cast<CXXTemporaryObjectExpr>(BTE->getSubExpr()))
     }
 
   // Otherwise just suggest adding a name. To find the place to insert the name
   // find the first TypeLoc in the children of E, which always points to the
   // written type.
   auto Matches =
       match(expr(hasDescendant(typeLoc().bind("t"))), *E, *Result.Context);
   const auto *TL = selectFirst<TypeLoc>("t", Matches);
+  assert(TL);
   D << FixItHint::CreateInsertion(
       Lexer::getLocForEndOfToken(TL->getEndLoc(), 0, *Result.SourceManager,
                                  getLangOpts()),
       Replacement);
 }
 
 } // namespace bugprone
 } // namespace tidy
 } // namespace clang

clang-tools-extra/test/clang-tidy/checkers/bugprone-unused-raii-crash.mm

+// RUN: clang-tidy %s -checks=-*,bugprone-unused-raii -- | count 0
+
+struct CxxClass {
+  ~CxxClass() {}
+};
+
+@interface ObjcClass {
+}
+- (CxxClass)set:(int)p;
+@end
+
+void test(ObjcClass *s) {
+  [s set:1]; // ok, no crash, no diagnostic emitted.
+  return;
+}