Page MenuHomePhabricator

[mlir][VectorOps] Lower vector.outerproduct of int vectors
ClosedPublic

Authored by bkramer on Jul 7 2020, 3:53 AM.

Details

Summary

vector.fma and mulf don't work on integers. Use a muli/addi pair or
plain muli instead.

Diff Detail

Event Timeline

bkramer created this revision.Jul 7 2020, 3:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2020, 3:53 AM
nicolasvasilache accepted this revision.Jul 7 2020, 4:40 AM
nicolasvasilache added inline comments.
mlir/lib/Dialect/Vector/VectorTransforms.cpp
1298–1301

nit: this inner if/else has become trivial so you can remove the braces

This revision is now accepted and ready to land.Jul 7 2020, 4:40 AM
This revision was automatically updated to reflect the committed changes.

LGTM, thanks!