This is an archive of the discontinued LLVM Phabricator instance.

clang CoverageMapping tests bot cleanup
ClosedPublic

Authored by lxfind on Jul 1 2020, 1:11 PM.

Details

Summary

D82928 generated unexpected tmp files in the CoverageMapping test directory. This patch cleans it up and remove the file in the test bots.
It will be revered after a week.

Diff Detail

Event Timeline

lxfind created this revision.Jul 1 2020, 1:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2020, 1:11 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
thakis accepted this revision.Jul 1 2020, 3:31 PM
This revision is now accepted and ready to land.Jul 1 2020, 3:31 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a subscriber: MaskRay.Jul 1 2020, 4:43 PM

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (--date=now is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))

llvm/utils/git/pre-push.py can validate the message does not include unneeded tags.

lxfind added a comment.Jul 1 2020, 4:55 PM

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (--date=now is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))

llvm/utils/git/pre-push.py can validate the message does not include unneeded tags.

Ah good to know. Thanks!