This is an archive of the discontinued LLVM Phabricator instance.

Differential D82946

[Driver][ARM] Disable bf16 when hardware FP support is missing
AbandonedPublic

Authored by vhscampos on Jul 1 2020, 4:22 AM.

Details

Reviewers
None

Diff Detail

Event Timeline

vhscampos created this revision.Jul 1 2020, 4:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2020, 4:22 AM
Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. · View Herald Transcript
vhscampos abandoned this revision.Jul 1 2020, 4:26 AM
Harbormaster failed remote builds in B62481: Diff 274755!Jul 1 2020, 4:51 AM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
Arch/
7 lines
test/
CodeGen/
4 lines

Diff 274755

clang/lib/Driver/ToolChains/Arch/ARM.cpp

Show First 20 Lines • Show All 295 Lines • ▼ Show 20 Lines return llvm::any_of(
Split, [](const StringRef &Extension) { return Extension == "nofp"; }); Split, [](const StringRef &Extension) { return Extension == "nofp"; });
}; };
if (ABI == arm::FloatABI::Soft) { if (ABI == arm::FloatABI::Soft) {
llvm::ARM::getFPUFeatures(llvm::ARM::FK_NONE, Features); llvm::ARM::getFPUFeatures(llvm::ARM::FK_NONE, Features);
// Disable all features relating to hardware FP, not already disabled by the // Disable all features relating to hardware FP, not already disabled by the
// above call. // above call.
Features.insert(Features.end(), Features.insert(Features.end(), {"-dotprod", "-fp16fml", "-bf16", "-mve",
{"-dotprod", "-fp16fml", "-mve", "-mve.fp", "-fpregs"}); "-mve.fp", "-fpregs"});
} else if (FPUID == llvm::ARM::FK_NONE || } else if (FPUID == llvm::ARM::FK_NONE ||
checkFPDisabledInArchName(ArchName)) { checkFPDisabledInArchName(ArchName)) {
// -mfpu=none or -march=armvX+nofp is *very* similar to -mfloat-abi=soft, // -mfpu=none or -march=armvX+nofp is *very* similar to -mfloat-abi=soft,
// only that it should not disable MVE-I. // only that it should not disable MVE-I.
Features.insert(Features.end(), {"-dotprod", "-fp16fml", "-mve.fp"}); Features.insert(Features.end(),
{"-dotprod", "-fp16fml", "-bf16", "-mve.fp"});
if (!hasIntegerMVE(Features)) { if (!hasIntegerMVE(Features)) {
Features.emplace_back("-fpregs"); Features.emplace_back("-fpregs");
} }
} }
} }
void arm::getARMTargetFeatures(const Driver &D, const llvm::Triple &Triple, void arm::getARMTargetFeatures(const Driver &D, const llvm::Triple &Triple,
const ArgList &Args, ArgStringList &CmdArgs, const ArgList &Args, ArgStringList &CmdArgs,
▲ Show 20 Lines • Show All 409 Lines • Show Last 20 Lines

clang/test/CodeGen/arm-bf16-softfloat.c

// RUN: not %clang -o %t.out -target arm-arm-eabi -march=armv8-a+bf16 -mfloat-abi=soft -c %s 2>&1 | FileCheck %s // RUN: not %clang -target arm-arm-none-eabi -march=armv8-a+bf16 -mfloat-abi=soft -c %s -o %t 2>&1 | FileCheck %s
// RUN: not %clang -target arm-arm-none-eabi -march=armv8-a+bf16 -mfpu=none -c %s -o %t 2>&1 | FileCheck %s
// RUN: not %clang -target arm-arm-none-eabi -march=armv8-a+bf16+nofp -c %s -o %t 2>&1 | FileCheck %s
// CHECK: error: __bf16 is not supported on this target // CHECK: error: __bf16 is not supported on this target
extern __bf16 var; extern __bf16 var;