This is an archive of the discontinued LLVM Phabricator instance.

Differential D82842

[mlir] Fix case in MLIRGPUtoNVVMTransforms
ClosedPublic

Authored by marbre on Jun 29 2020, 11:40 PM.

Details

Reviewers
stephenneuendorffer
herhut
Commits
rG7099d8e4f7d0: [mlir] Fix case in MLIRGPUtoNVVMTransforms
Summary

This changes the casing of MLIRGPUtoNVVMTransforms to be consistent
with other transform libraries.

Diff Detail

Event Timeline

marbre created this revision.Jun 29 2020, 11:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2020, 11:40 PM
Herald added subscribers: msifontes, jurahul, Kayjukh and 16 others. · View Herald Transcript
Harbormaster completed remote builds in B62278: Diff 274342.Jun 30 2020, 12:30 AM
herhut accepted this revision.Jun 30 2020, 12:52 AM

Thanks!

This revision is now accepted and ready to land.Jun 30 2020, 12:52 AM
marbre added a comment.Jun 30 2020, 1:52 AM

Thanks for the review! I would appreciate if you could commit on my behalf.

Closed by commit rG7099d8e4f7d0: [mlir] Fix case in MLIRGPUtoNVVMTransforms (authored by marbre, committed by herhut). · Explain WhyJun 30 2020, 11:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Conversion/
GPUToNVVM/
2 lines

Diff 274571

mlir/lib/Conversion/GPUToNVVM/CMakeLists.txt

set(LLVM_TARGET_DEFINITIONS GPUToNVVM.td) set(LLVM_TARGET_DEFINITIONS GPUToNVVM.td)
mlir_tablegen(GPUToNVVM.cpp.inc -gen-rewriters) mlir_tablegen(GPUToNVVM.cpp.inc -gen-rewriters)
add_public_tablegen_target(MLIRGPUToNVVMIncGen) add_public_tablegen_target(MLIRGPUToNVVMIncGen)
add_mlir_conversion_library(MLIRGPUtoNVVMTransforms add_mlir_conversion_library(MLIRGPUToNVVMTransforms
LowerGpuOpsToNVVMOps.cpp LowerGpuOpsToNVVMOps.cpp
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
MLIRGPUToNVVMIncGen MLIRGPUToNVVMIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRGPU MLIRGPU
MLIRLLVMIR MLIRLLVMIR
MLIRNVVMIR MLIRNVVMIR
MLIRPass MLIRPass
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRTransformUtils MLIRTransformUtils
) )