This is an archive of the discontinued LLVM Phabricator instance.

Differential D82766

Compile the RecursiveASTVisitor callbacks test with "/bigobj"
ClosedPublic

Authored by gribozavr on Jun 29 2020, 6:47 AM.

Details

Reviewers
erichkeane
Commits
rG1cf2e45c19ff: Compile the RecursiveASTVisitor callbacks test with "/bigobj"
Summary

This file was exceeding a limit in MSVC:

fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj

Diff Detail

Event Timeline

gribozavr created this revision.Jun 29 2020, 6:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2020, 6:47 AM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
gribozavr2 added a reviewer: erichkeane.Jun 29 2020, 6:47 AM
erichkeane accepted this revision.Jun 29 2020, 6:49 AM
erichkeane added inline comments.
clang/unittests/Tooling/CMakeLists.txt
10

Just a nit, but I think we want to alphabetically order these like include files (so after the ExprVisitor below).

This revision is now accepted and ready to land.Jun 29 2020, 6:49 AM
gribozavr updated this revision to Diff 274108.Jun 29 2020, 7:08 AM

Order lines alphabetically.

gribozavr2 added a subscriber: gribozavr2.Jun 29 2020, 7:08 AM
gribozavr2 added inline comments.
clang/unittests/Tooling/CMakeLists.txt
10

Done, thanks!

jmorse added a subscriber: jmorse.Jun 29 2020, 7:30 AM
Harbormaster failed remote builds in B62141: Diff 274094!Jun 29 2020, 7:31 AM
Harbormaster failed remote builds in B62148: Diff 274108!Jun 29 2020, 8:04 AM
Closed by commit rG1cf2e45c19ff: Compile the RecursiveASTVisitor callbacks test with "/bigobj" (authored by gribozavr). · Explain WhyJun 29 2020, 8:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
unittests/
Tooling/
1 line

Diff 274135

clang/unittests/Tooling/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
FrontendOpenMP FrontendOpenMP
Support Support
) )
# By default MSVC has a 2^16 limit on the number of sections in an object file, # By default MSVC has a 2^16 limit on the number of sections in an object file,
# and this needs more than that. # and this needs more than that.
if (MSVC) if (MSVC)
set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj) set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj)
erichkeaneUnsubmitted
Not Done
ReplyInline Actions

Just a nit, but I think we want to alphabetically order these like include files (so after the ExprVisitor below).

erichkeane: Just a nit, but I think we want to alphabetically order these like include files (so after the…
gribozavr2Unsubmitted
Not Done
ReplyInline Actions

Done, thanks!

gribozavr2: Done, thanks!
set_source_files_properties(RecursiveASTVisitorTestExprVisitor.cpp PROPERTIES COMPILE_FLAGS /bigobj) set_source_files_properties(RecursiveASTVisitorTestExprVisitor.cpp PROPERTIES COMPILE_FLAGS /bigobj)
set_source_files_properties(RecursiveASTVisitorTests/Callbacks.cpp PROPERTIES COMPILE_FLAGS /bigobj)
set_source_files_properties(SourceCodeTest.cpp PROPERTIES COMPILE_FLAGS /bigobj) set_source_files_properties(SourceCodeTest.cpp PROPERTIES COMPILE_FLAGS /bigobj)
endif() endif()
add_clang_unittest(ToolingTests add_clang_unittest(ToolingTests
ASTSelectionTest.cpp ASTSelectionTest.cpp
CastExprTest.cpp CastExprTest.cpp
CommentHandlerTest.cpp CommentHandlerTest.cpp
CompilationDatabaseTest.cpp CompilationDatabaseTest.cpp
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines