diff --git a/llvm/include/llvm/Analysis/CallGraph.h b/llvm/include/llvm/Analysis/CallGraph.h --- a/llvm/include/llvm/Analysis/CallGraph.h +++ b/llvm/include/llvm/Analysis/CallGraph.h @@ -412,7 +412,7 @@ // graphs by the generic graph algorithms. // -// Provide graph traits for tranversing call graphs using standard graph +// Provide graph traits for traversing call graphs using standard graph // traversals. template <> struct GraphTraits { using NodeRef = CallGraphNode *; diff --git a/llvm/lib/Analysis/CallGraphSCCPass.cpp b/llvm/lib/Analysis/CallGraphSCCPass.cpp --- a/llvm/lib/Analysis/CallGraphSCCPass.cpp +++ b/llvm/lib/Analysis/CallGraphSCCPass.cpp @@ -230,17 +230,16 @@ // If this call site is null, then the function pass deleted the call // entirely and the WeakTrackingVH nulled it out. auto *Call = dyn_cast_or_null(I->first); - if (!I->first || + if (!Call || // If we've already seen this call site, then the FunctionPass RAUW'd // one call with another, which resulted in two "uses" in the edge // list of the same call. - Calls.count(I->first) || + Calls.count(Call) || // If the call edge is not from a call or invoke, or it is a // instrinsic call, then the function pass RAUW'd a call with // another value. This can happen when constant folding happens // of well known functions etc. - !Call || (Call->getCalledFunction() && Call->getCalledFunction()->isIntrinsic() && Intrinsic::isLeaf(Call->getCalledFunction()->getIntrinsicID()))) { @@ -267,14 +266,13 @@ continue; } - assert(!Calls.count(I->first) && - "Call site occurs in node multiple times"); + assert(!Calls.count(Call) && "Call site occurs in node multiple times"); if (Call) { Function *Callee = Call->getCalledFunction(); // Ignore intrinsics because they're not really function calls. if (!Callee || !(Callee->isIntrinsic())) - Calls.insert(std::make_pair(I->first, I->second)); + Calls.insert(std::make_pair(Call, I->second)); } ++I; } diff --git a/llvm/lib/Transforms/IPO/SyntheticCountsPropagation.cpp b/llvm/lib/Transforms/IPO/SyntheticCountsPropagation.cpp --- a/llvm/lib/Transforms/IPO/SyntheticCountsPropagation.cpp +++ b/llvm/lib/Transforms/IPO/SyntheticCountsPropagation.cpp @@ -109,8 +109,7 @@ Optional Res = None; if (!Edge.first) return Res; - assert(isa(Edge.first)); - CallBase &CB = cast(*Edge.first); + CallBase &CB = *cast(Edge.first); Function *Caller = CB.getCaller(); auto &BFI = FAM.getResult(*Caller);