This is an archive of the discontinued LLVM Phabricator instance.

Pass a process full executable path within "name" response field.
ClosedPublic

Authored by ovyalov on Mar 10 2015, 5:08 PM.

Details

Reviewers
vharron
clayborg
Summary

Pass a full executable path within "name" response field for q*ProcessInfo commands so lldb host can get a full executable path for a process.
Client side already expects this field to be a full path - "process_info.GetExecutableFile().SetFile (value.c_str(), false);" - https://github.com/llvm-mirror/lldb/blob/master/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp#L2356

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 21661.Mar 10 2015, 5:08 PM
ovyalov retitled this revision from to Pass a process full executable path within "name" response field..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added reviewers: clayborg, vharron.
ovyalov added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Mar 10 2015, 5:14 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Mar 10 2015, 5:14 PM
ovyalov closed this revision.Mar 11 2015, 11:18 AM

AFFECTED FILES

/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

USERS

ovyalov (Author)

http://reviews.llvm.org/rL231949