This is an archive of the discontinued LLVM Phabricator instance.

Fix bug in ProcessGDBRemote
ClosedPublic

Authored by labath on Mar 10 2015, 11:26 AM.

Details

Summary

ProcessGDBRemote::AsyncThread nuked its own thread handle upon exiting. This prevented the main
thread from joining it correctly in StopAsyncThread. I address this by moving the Reset() call to
StopAsyncThread, after the join.

Diff Detail

Event Timeline

labath updated this revision to Diff 21609.Mar 10 2015, 11:26 AM
labath retitled this revision from to Fix bug in ProcessGDBRemote.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added reviewers: clayborg, zturner.
labath added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Mar 10 2015, 1:48 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2015, 1:48 PM
This revision was automatically updated to reflect the committed changes.