Initialize ProcessGDBRemoteLog for LLGS to fix remote platform logging

[flackr]

Summary

This was previously initialized by ProcessGDBRemote::Initialize but lldb-server does not contain ProcessGDBRemote anymore so this needs to be initialized directly.

[ovyalov]

Please see my comments.

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

142

Maybe introduce ProcessGDBRemoteLog::Initialize() instead of this method?

We can put

Log::Callbacks log_callbacks = {
            ProcessGDBRemoteLog::DisableLog,
            ProcessGDBRemoteLog::EnableLog,
            ProcessGDBRemoteLog::ListLogCategories
        };

        Log::RegisterLogChannel (g_name, log_callbacks);

inside of ProcessGDBRemoteLog::Initialize and call it from ProcessGDBRemote::Initialize and lldb-server.cpp.

147

Could you use std::call_once here?

tools/lldb-server/lldb-server.cpp

11

GDBRemoteCommunication.h ?

[tberghammer]

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

142

I like your idea about creating ProcessGDBRemoteLog::Initialize, but I would prefer to call it from lldb.cpp:initializeLLGS().

[flackr]

Move Log initialization to Log class Initialize functions and use std::call_once to guard against multiple calls.

[flackr]

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

142

Done, for ProcessPOSIXLog as well.

147

Done.

tools/lldb-server/lldb-server.cpp

11

Oops, done.

[tberghammer]

Please update ProcessFreeBSD::Initialize() to use the newly created ProcessPOSIXLog::Initialize() function.

source/Plugins/Process/Linux/ProcessLinux.cpp

64 ↗

(On Diff #21668)

Please move this line into ProcessPOSIXLog::Initialize()

source/Plugins/Process/POSIX/ProcessPOSIXLog.cpp

41 ↗

(On Diff #21668)

Please make it an argument, instead of a hard coded string.

[flackr]

Added argument to ProcessPOSIXLog to specify log channel name, called from ProcessFreeBSD::Initialize as well.

source/Plugins/Process/Linux/ProcessLinux.cpp

64 ↗

(On Diff #21668)

Done.

source/Plugins/Process/POSIX/ProcessPOSIXLog.cpp

41 ↗

(On Diff #21668)

Done.

[ovyalov]

Looks good.

tools/lldb-server/lldb-gdbserver.cpp

490 ↗

(On Diff #21720)

We'll need to apply such conditional compilation in lldb-platform.cpp as well https://github.com/llvm-mirror/lldb/blob/master/tools/lldb-server/lldb-platform.cpp#L108 - but not necessary for this CL.

[tberghammer]

tools/lldb-server/lldb-gdbserver.cpp

490 ↗

(On Diff #21720)

lldb-platform not used on Windows (at least not yet)

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h

public:
         ~ScopedTimeout ();
 
     private:
         GDBRemoteCommunication& m_gdb_comm;
         uint32_t m_saved_timeout;
     };
 
     //------------------------------------------------------------------
+    // Public Static Methods
+    //------------------------------------------------------------------
+    static void
+    Initialize();
+
+    //------------------------------------------------------------------
     // Constructors and Destructors
     //------------------------------------------------------------------
     GDBRemoteCommunication(const char *comm_name, 
                            const char *listener_name);
 
     virtual
     ~GDBRemoteCommunication();
 

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

if (log && !m_dumped_to_log)
                          entry.tid,
                          entry.bytes_transmitted,
                          (entry.type == ePacketTypeSend) ? "send" : "read",
                          entry.packet.c_str());
         }
     }
 }
 
+void
+GDBRemoteCommunication::Initialize()
+{
+    static ConstString g_name("gdb-remote");
+    static bool g_initialized = false;
+
+    if (g_initialized == false)
+    {
+        g_initialized = true;
+
+        Log::Callbacks log_callbacks = {
+            ProcessGDBRemoteLog::DisableLog,
+            ProcessGDBRemoteLog::EnableLog,
+            ProcessGDBRemoteLog::ListLogCategories
+        };
+
+        Log::RegisterLogChannel (g_name, log_callbacks);
+    }
+}
+
 //----------------------------------------------------------------------
 // GDBRemoteCommunication constructor
 //----------------------------------------------------------------------
 GDBRemoteCommunication::GDBRemoteCommunication(const char *comm_name, 
                                                const char *listener_name) :
     Communication(comm_name),
 #ifdef LLDB_CONFIGURATION_DEBUG
     m_packet_timeout (1000),

tools/lldb-server/lldb-server.cpp

 //===-- lldb-server.cpp -----------------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "lldb/lldb-private.h"
+#include "Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp"
 
 #include <stdio.h>
 #include <stdlib.h>
 
 static void
 display_usage (const char *progname)
 {
     fprintf(stderr, "Usage:\n"
             "  %s g[dbserver] [options]\n"
             "  %s p[latform] [options]\n"
             "Invoke subcommand for additional help\n", progname, progname);
     exit(0);
 }
 
 // Forward declarations of subcommand main methods.
 int main_gdbserver (int argc, char *argv[]);
 int main_platform (int argc, char *argv[]);
 
 static void
 initialize ()
 {
     lldb_private::InitializeForLLGS();
+    GDBRemoteCommunication::Initialize();
 }
 
 static void
 terminate ()
 {
     lldb_private::WillTerminate();
     lldb_private::TerminateLLGS();
 }