This is an archive of the discontinued LLVM Phabricator instance.

[NFC][PowerPC] Add a multiclass for fsetcc to define them in a uniform way
ClosedPublic

Authored by steven.zhang on Jun 11 2020, 8:39 PM.

Details

Summary

This is a refactor patch to prepare for adding the support for strict-fsetcc in PowerPC backend. We want to move their definition into a uniform way so that, we could add the strict node easier.

Diff Detail

Event Timeline

steven.zhang created this revision.Jun 11 2020, 8:39 PM

This is a nice refactor. The only thing I would like to see is a statement to indicate that you have ensured that PPCGenDAGISel.inc is identical before and after this patch.

llvm/lib/Target/PowerPC/PPCInstrInfo.td
3947

Unrelated and unnecessary whitespace addition.

This is a nice refactor. The only thing I would like to see is a statement to indicate that you have ensured that PPCGenDAGISel.inc is identical before and after this patch.

Yes, they are completely the same. I will remove that whitespace when I commit this patch.

steven.zhang marked an inline comment as done.Jun 22 2020, 4:18 PM

Gentle ping...

shchenz accepted this revision.Jul 16 2020, 6:36 PM

LGTM. Please fix the redundant line in @nemanjai comments when you commit this.

This revision is now accepted and ready to land.Jul 16 2020, 6:36 PM
This revision was landed with ongoing or failed builds.Aug 2 2020, 8:41 PM
This revision was automatically updated to reflect the committed changes.