Index: clang/lib/CodeGen/CodeGenModule.h =================================================================== --- clang/lib/CodeGen/CodeGenModule.h +++ clang/lib/CodeGen/CodeGenModule.h @@ -790,6 +790,9 @@ /// variable declaration D. void setTLSMode(llvm::GlobalValue *GV, const VarDecl &D) const; + /// Get LLVM TLS mode from CodeGenOptions. + llvm::GlobalVariable::ThreadLocalMode GetDefaultLLVMTLSModel() const; + static llvm::GlobalValue::VisibilityTypes GetLLVMVisibility(Visibility V) { switch (V) { case DefaultVisibility: return llvm::GlobalValue::DefaultVisibility; Index: clang/lib/CodeGen/CodeGenModule.cpp =================================================================== --- clang/lib/CodeGen/CodeGenModule.cpp +++ clang/lib/CodeGen/CodeGenModule.cpp @@ -971,9 +971,9 @@ .Case("local-exec", llvm::GlobalVariable::LocalExecTLSModel); } -static llvm::GlobalVariable::ThreadLocalMode GetLLVMTLSModel( - CodeGenOptions::TLSModel M) { - switch (M) { +llvm::GlobalVariable::ThreadLocalMode +CodeGenModule::GetDefaultLLVMTLSModel() const { + switch (CodeGenOpts.getDefaultTLSModel()) { case CodeGenOptions::GeneralDynamicTLSModel: return llvm::GlobalVariable::GeneralDynamicTLSModel; case CodeGenOptions::LocalDynamicTLSModel: @@ -990,7 +990,7 @@ assert(D.getTLSKind() && "setting TLS mode on non-TLS var!"); llvm::GlobalValue::ThreadLocalMode TLM; - TLM = GetLLVMTLSModel(CodeGenOpts.getDefaultTLSModel()); + TLM = GetDefaultLLVMTLSModel(); // Override the TLS model if it is explicitly specified. if (const TLSModelAttr *Attr = D.getAttr()) { Index: clang/lib/CodeGen/ItaniumCXXABI.cpp =================================================================== --- clang/lib/CodeGen/ItaniumCXXABI.cpp +++ clang/lib/CodeGen/ItaniumCXXABI.cpp @@ -2619,6 +2619,7 @@ llvm::GlobalVariable::InternalLinkage, llvm::ConstantInt::get(CGM.Int8Ty, 0), "__tls_guard"); Guard->setThreadLocal(true); + Guard->setThreadLocalMode(CGM.GetDefaultLLVMTLSModel()); CharUnits GuardAlign = CharUnits::One(); Guard->setAlignment(GuardAlign.getAsAlign()); Index: clang/test/CodeGen/tls-model.cpp =================================================================== --- clang/test/CodeGen/tls-model.cpp +++ clang/test/CodeGen/tls-model.cpp @@ -16,29 +16,52 @@ } int __thread __attribute__((tls_model("initial-exec"))) z; +struct S { + S(); + ~S(); +}; +struct T { + ~T(); +}; + +struct S thread_local s1; +struct T thread_local t1; + // Note that unlike normal C uninitialized global variables, // uninitialized TLS variables do NOT have COMMON linkage. // CHECK-GD: @z1 = global i32 0 -// CHECK-GD: @f.y = internal thread_local global i32 0 // CHECK-GD: @z2 = global i32 0 // CHECK-GD: @x = thread_local global i32 0 +// CHECK-GD: @_ZZ1fvE1y = internal thread_local global i32 0 // CHECK-GD: @z = thread_local(initialexec) global i32 0 +// CHECK-GD: @s1 = thread_local global %struct.S zeroinitializer +// CHECK-GD: @t1 = thread_local global %struct.T zeroinitializer +// CHECK-GD: @__tls_guard = internal thread_local global i8 0 // CHECK-LD: @z1 = global i32 0 -// CHECK-LD: @f.y = internal thread_local(localdynamic) global i32 0 // CHECK-LD: @z2 = global i32 0 // CHECK-LD: @x = thread_local(localdynamic) global i32 0 +// CHECK-LD: @_ZZ1fvE1y = internal thread_local(localdynamic) global i32 0 // CHECK-LD: @z = thread_local(initialexec) global i32 0 +// CHECK-LD: @s1 = thread_local(localdynamic) global %struct.S zeroinitializer +// CHECK-LD: @t1 = thread_local(localdynamic) global %struct.T zeroinitializer +// CHECK-LD: @__tls_guard = internal thread_local(localdynamic) global i8 0 // CHECK-IE: @z1 = global i32 0 -// CHECK-IE: @f.y = internal thread_local(initialexec) global i32 0 // CHECK-IE: @z2 = global i32 0 // CHECK-IE: @x = thread_local(initialexec) global i32 0 +// CHECK-IE: @_ZZ1fvE1y = internal thread_local(initialexec) global i32 0 // CHECK-IE: @z = thread_local(initialexec) global i32 0 +// CHECK-IE: @s1 = thread_local(initialexec) global %struct.S zeroinitializer +// CHECK-IE: @t1 = thread_local(initialexec) global %struct.T zeroinitializer +// CHECK-IE: @__tls_guard = internal thread_local(initialexec) global i8 0 // CHECK-LE: @z1 = global i32 0 -// CHECK-LE: @f.y = internal thread_local(localexec) global i32 0 // CHECK-LE: @z2 = global i32 0 // CHECK-LE: @x = thread_local(localexec) global i32 0 +// CHECK-LE: @_ZZ1fvE1y = internal thread_local(localexec) global i32 0 // CHECK-LE: @z = thread_local(initialexec) global i32 0 +// CHECK-LE: @s1 = thread_local(localexec) global %struct.S zeroinitializer +// CHECK-LE: @t1 = thread_local(localexec) global %struct.T zeroinitializer +// CHECK-LE: @__tls_guard = internal thread_local(localexec) global i8 0