This is an archive of the discontinued LLVM Phabricator instance.

[TEST] TreeTest.cpp - Add a comma to avoid build error with -werror
ClosedPublic

Authored by skan on Jun 8 2020, 6:54 AM.

Details

Summary

The macro INSTANTIATE_TEST_CASE_P is defined as

\# define INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator, ...) \
...

If we build the test case with -werror, we will get an error like

error: ISO C++11 requires at least one argument for the "..." in a
variadic macro

testing::ValuesIn(TestClangConfig::allConfigs()));
                                                ^

This patch fixes that.

Diff Detail

Event Timeline

skan created this revision.Jun 8 2020, 6:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2020, 6:54 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
skan added a comment.Jun 8 2020, 7:13 AM

Related revision: D80822

gribozavr2 accepted this revision.Jun 8 2020, 7:14 AM
This revision is now accepted and ready to land.Jun 8 2020, 7:14 AM
This revision was automatically updated to reflect the committed changes.