Added checks for BinaryOperation, InsertElement, ExtractElement and changed return value in FunctionComparator

[vish99]

Summary

Added special checks for BinaryOperator, InsertElement, ExtractElement since the return value is changed to return the left operation is greater if the operation opcode is not seen so far. This will not return unknown operations as equal.

[lebedev.ri]

Test?

llvm/lib/Transforms/Utils/FunctionComparator.cpp

if (const PHINode *PNL = dyn_cast<PHINode>(L)) {
     // (checked by the caller of this function), the incoming blocks
     // are also identical.
     for (unsigned i = 0, e = PNL->getNumIncomingValues(); i != e; ++i) {
       if (int Res =
               cmpValues(PNL->getIncomingBlock(i), PNR->getIncomingBlock(i)))
         return Res;
     }
   }
+
+  if (isa<BinaryOperator>(L)) {
+    // Binary operation instructions and logical operation instructions have
+    // already been compared for opcode, number of operands, operation types,
+    // subclass optional data, operand types
+    return 0;
+  }
+  if (isa<InsertElementInst>(L) || isa<ExtractElementInst>(L)) {
+    // InsertElement and ExtractElement instructions have already been compared
+    // for opcode, number of operands, operation types, subclass optional data,
+    // operand types
     return 0;
   }
 
+  // Return left operation to be greater in case of instructions which are
+  // not seen.
+  return 1;
+}
+
 // Determine whether two GEP operations perform the same underlying arithmetic.
 // Read method declaration comments for more details.
 int FunctionComparator::cmpGEPs(const GEPOperator *GEPL,
                                 const GEPOperator *GEPR) const {
   unsigned int ASL = GEPL->getPointerAddressSpace();
   unsigned int ASR = GEPR->getPointerAddressSpace();
 
   if (int Res = cmpNumbers(ASL, ASR))