This is an archive of the discontinued LLVM Phabricator instance.

[AddressSanitizer] Don't use weak linkage for __{start,stop}_asan_globals
ClosedPublic

Authored by mcgrathr on May 26 2020, 7:58 PM.

Details

Summary

It should not be necessary to use weak linkage for these. Doing so
implies interposablity and thus PIC generates indirections and
dynamic relocations, which are unnecessary and suboptimal. Aside
from this, ASan instrumentation never introduces GOT indirection
relocations where there were none before--only new absolute relocs
in RELRO sections for metadata, which are less problematic for
special linkage situations that take pains to avoid GOT generation.

Diff Detail

Event Timeline

mcgrathr created this revision.May 26 2020, 7:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2020, 7:58 PM
This revision is now accepted and ready to land.May 29 2020, 12:53 PM
mcgrathr added a reviewer: Restricted Project.May 29 2020, 1:15 PM
This revision was automatically updated to reflect the committed changes.