diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -2335,6 +2335,7 @@ uint64_t Op0Idx; uint64_t Op1Idx; uint64_t Op2Idx; + unsigned CstNo; }; std::vector DelayedShuffles; while (true) { @@ -2348,9 +2349,6 @@ case BitstreamEntry::Error: return error("Malformed block"); case BitstreamEntry::EndBlock: - if (NextCstNo != ValueList.size()) - return error("Invalid constant reference"); - // Once all the constants have been read, go through and resolve forward // references. // @@ -2363,6 +2361,7 @@ uint64_t Op0Idx = DelayedShuffle.Op0Idx; uint64_t Op1Idx = DelayedShuffle.Op1Idx; uint64_t Op2Idx = DelayedShuffle.Op2Idx; + uint64_t CstNo = DelayedShuffle.CstNo; Constant *Op0 = ValueList.getConstantFwdRef(Op0Idx, OpTy); Constant *Op1 = ValueList.getConstantFwdRef(Op1Idx, OpTy); Type *ShufTy = @@ -2373,9 +2372,12 @@ SmallVector Mask; ShuffleVectorInst::getShuffleMask(Op2, Mask); Value *V = ConstantExpr::getShuffleVector(Op0, Op1, Mask); - ValueList.assignValue(V, NextCstNo, DelayedShuffle.CurFullTy); - ++NextCstNo; + ValueList.assignValue(V, CstNo, DelayedShuffle.CurFullTy); } + + if (NextCstNo != ValueList.size()) + return error("Invalid constant reference"); + ValueList.resolveConstantForwardRefs(); return Error::success(); case BitstreamEntry::Record: @@ -2735,7 +2737,8 @@ if (Record.size() < 3 || !OpTy) return error("Invalid record"); DelayedShuffles.push_back( - {OpTy, OpTy, CurFullTy, Record[0], Record[1], Record[2]}); + {OpTy, OpTy, CurFullTy, Record[0], Record[1], Record[2], NextCstNo}); + ++NextCstNo; continue; } case bitc::CST_CODE_CE_SHUFVEC_EX: { // [opty, opval, opval, opval] @@ -2745,7 +2748,8 @@ if (Record.size() < 4 || !RTy || !OpTy) return error("Invalid record"); DelayedShuffles.push_back( - {OpTy, RTy, CurFullTy, Record[1], Record[2], Record[3]}); + {OpTy, RTy, CurFullTy, Record[1], Record[2], Record[3], NextCstNo}); + ++NextCstNo; continue; } case bitc::CST_CODE_CE_CMP: { // CE_CMP: [opty, opval, opval, pred] diff --git a/llvm/test/Bitcode/vscale-shuffle.ll b/llvm/test/Bitcode/vscale-shuffle.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Bitcode/vscale-shuffle.ll @@ -0,0 +1,10 @@ +; RUN: llvm-as < %s | llvm-dis -disable-output +; RUN: verify-uselistorder < %s + +define void @f() { + %l = call @l( shufflevector ( insertelement ( undef, i1 true, i32 0), undef, zeroinitializer)) + %i = add undef, shufflevector ( insertelement ( undef, i64 1, i32 0), undef, zeroinitializer) + unreachable +} + +declare @l()