This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Fix splitting wide VALU, non-vector loads
ClosedPublic

Authored by arsenm on May 17 2020, 5:18 PM.

Details

Diff Detail

Event Timeline

arsenm created this revision.May 17 2020, 5:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2020, 5:18 PM
kerbowa accepted this revision.May 17 2020, 5:52 PM

LGTM

llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-load.mir
44

Random nit, the suffix for constant.not.uniform is not consistent with the other tests.

51

Ditto.

This revision is now accepted and ready to land.May 17 2020, 5:52 PM
arsenm closed this revision.May 18 2020, 9:20 AM
arsenm marked an inline comment as done.
llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-load.mir
44

The type suffix on the value name just adds more effort when copying other tests. It should be removed from the rest