This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [COFF] Fix def file exporting of symbols containing periods
ClosedPublic

Authored by mstorsjo on May 8 2020, 1:09 AM.

Details

Summary

This fixes an accidental breakage of exporting symbols using def files, when the symbol name contains a period, since commit 0ca06f7950e5, mixing up a symbol name containing a period with the case of exporting a symbol as a forward to another dll.

Diff Detail

Event Timeline

mstorsjo created this revision.May 8 2020, 1:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2020, 1:09 AM

Confirming that this patch fixes linking MinGW Rust with LLD.

rnk accepted this revision.May 9 2020, 8:19 AM

lgtm

This revision is now accepted and ready to land.May 9 2020, 8:19 AM
This revision was automatically updated to reflect the committed changes.