This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs
ClosedPublic

Authored by vsavchenko on Apr 30 2020, 1:13 AM.

Details

Summary

SymIntExpr, IntSymExpr, and SymSymExpr share a big portion of logic
that used to be duplicated across all three classes. New
implementation also adds an easy way of introducing another type of
operands into the mix.

Diff Detail

Event Timeline

vsavchenko created this revision.Apr 30 2020, 1:13 AM
xazax.hun accepted this revision.Apr 30 2020, 5:01 AM

Nice catch, LGTM!

This revision is now accepted and ready to land.Apr 30 2020, 5:01 AM
NoQ accepted this revision.Apr 30 2020, 5:53 AM

That's... pretty neat. I wouldn't have thought of that. Looking forward to those SymLocAsIntegerExprs.

This revision was automatically updated to reflect the committed changes.