Page MenuHomePhabricator

[ValueTracking] Handle shufflevector constants in ComputeNumSignBits
ClosedPublic

Authored by efriedma on Apr 22 2020, 5:18 PM.

Diff Detail

Event Timeline

efriedma created this revision.Apr 22 2020, 5:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2020, 5:18 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
huihuiz accepted this revision.Apr 22 2020, 8:37 PM

Looks fine with me.

llvm/test/Transforms/InstCombine/nsw.ll
138

Not needed, just shuffle(insertelement) + mul will get this crash.
But not very important.

This revision is now accepted and ready to land.Apr 22 2020, 8:37 PM
efriedma marked an inline comment as done.Apr 23 2020, 5:46 PM
efriedma added inline comments.
llvm/test/Transforms/InstCombine/nsw.ll
138

Since I'm here, might as well add a testcase where we could, in theory, mark the mul as nsw/nuw.

This revision was automatically updated to reflect the committed changes.