[Dexter] Add os.path.normcase(...) transform to test path early.

[TWeaver]

Summary

When passing a test path, if the path points directly at a file, then normcase would not be called on path.

This would change the expected lower case drive path, on windows, to be uppercase.

This patch simply calls normcase on the test path at the earliest point possible to avoid this issue.

[TWeaver]

removed accidental new line deletion

[jmorse]

LGTM -- this caused some kind of test failure due to Dexter not recognising the source files, right?

[djtodoro]

debuginfo-tests/dexter/dex/tools/TestToolBase.py

82

All in one line os.path.normcase(os.path.abspath(options.test_path))) ?

[TWeaver]

@jmorse

no, this would cause file path comparisons that are case sensitive to potentially fail on drive letter for windows.

on investigation is seems the drive letter strings in the windows debug info is lower case, but in dexter we're storing an uppercase when passing a direct file path.

This did cause issues in the on going conditional break point work but may also cause discrepancies in other tests when running under windows.

[TWeaver]

@djtodoro

I prefer the current approach for readabilities sake as well as separating the two method calls out.

I feel if someone wished to add more code to the path calculation (what ever future reason, should one exist) then the separation shows the distinct steps that already take place.

Two lines does mean however, should someone wish to move these calls, they'd have to read both lines and move them together.

So it's a toss up of which benefit is preferred. I prefer two lines for readabilities sake.

It hardly matters of course and if you insist then I'm happy to accommodate.

Cheers
Tom W

[djtodoro]

@TWeaver I don't have strong opinion about that, so I am OK with either way. :)

[TWeaver]

Landed in commit rGbf1cdc2c6c0460b7121ac653c796ef4995b1dfa9

debuginfo-tests/dexter/dex/tools/TestToolBase.py

def handle_options(self, defaults):
                 raise Error(e)
 
         try:
             handle_debugger_tool_options(self.context, defaults)
         except ToolArgumentError as e:
             raise Error(e)
 
         options.test_path = os.path.abspath(options.test_path)
+        options.test_path = os.path.normcase(options.test_path)
         if not os.path.isfile(options.test_path) and not os.path.isdir(options.test_path):
             raise Error(
                 '<d>could not find test path</> <r>"{}"</>'.format(
                     options.test_path))
 
         options.results_directory = os.path.abspath(options.results_directory)
         if not os.path.isdir(options.results_directory):
             try: