[mlir] Extended Alloc and Dealloc operations with memory-effect traits.

[bondhugula]

"Extended Alloc ..." -> "[MLIR] Extend Alloc ..."

Can you please add a commit summary even if brief?

[dfki-jugr]

Updated commit message and added a short summary.

[lebedev.ri]

In D78619#1996489, @dfki-jugr wrote:

Updated commit message and added a short summary.

That needs to be done in phabricator, clearly whatever tool is being used to update the reviews (arc?) does not do any of that.

[mehdi_amini]

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

139

Any reason this is not just always tagged "MemAlloc"?

[mehdi_amini]

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

139

Seems like we could take an optional string to tag the resource / pool for the alloc, but always mark the result as MemAlloc?

[dfki-jugr]

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

139

Good point, this makes sense. We will address it in an follow up PR.

[mehdi_amini]

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

139

I'm curious why didn't address it here in the first place instead?

[dfki-jugr]

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

139

We wanted to provide a more generalized approach for this. Follow this link to get to the follow up PR: https://reviews.llvm.org/D78917

[mehdi_amini]

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

139

I still don't understand why the current revision needed to land first...

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

 class FloatArithmeticOp<string mnemonic, list<OpTrait> traits = []> :
     ArithmeticOp<mnemonic, traits>,
     Arguments<(ins FloatLike:$lhs, FloatLike:$rhs)>;
 
 // Base class for memref allocating ops: alloca and alloc.
 //
 //   %0 = alloclike(%m)[%s] : memref<8x?xf32, (d0, d1)[s0] -> ((d0 + s0), d1)>
 //
-class AllocLikeOp<string mnemonic, list<OpTrait> traits = []> :
+class AllocLikeOp<string mnemonic,
+                  list<OpVariableDecorator> resultDecorators = [],
+                  list<OpTrait> traits = []> :
     Std_Op<mnemonic, traits> {
 
   let arguments = (ins Variadic<Index>:$value,
                    Confined<OptionalAttr<I64Attr>, [IntMinValue<0>]>:$alignment);
-  let results = (outs AnyMemRef);
+  let results = (outs Arg<AnyMemRef, "", resultDecorators>);
 
   let builders = [OpBuilder<
     "Builder *builder, OperationState &result, MemRefType memrefType", [{
        result.types.push_back(memrefType);
      }]>,
     OpBuilder<
     "Builder *builder, OperationState &result, MemRefType memrefType, " #
     "ValueRange operands, IntegerAttr alignment = IntegerAttr()", [{
def AddIOp : IntArithmeticOp<"addi", [Commutative]> {
   }];
   let hasFolder = 1;
 }
 
 //===----------------------------------------------------------------------===//
 // AllocOp
 //===----------------------------------------------------------------------===//
 
-def AllocOp : AllocLikeOp<"alloc"> {
+def AllocOp : AllocLikeOp<"alloc", [MemAlloc], [MemoryEffects<[MemAlloc]>]> {
   let summary = "memory allocation operation";
   let description = [{
     The `alloc` operation allocates a region of memory, as specified by its
     memref type.
 
     Example:
 
     ```mlir
let description = [{
     ```
   }];
 }
 
 //===----------------------------------------------------------------------===//
 // DeallocOp
 //===----------------------------------------------------------------------===//
 
-def DeallocOp : Std_Op<"dealloc"> {
+def DeallocOp : Std_Op<"dealloc", [MemoryEffects<[MemFree]>]> {
   let summary = "memory deallocation operation";
   let description = [{
     The `dealloc` operation frees the region of memory referenced by a memref
     which was originally created by the `alloc` operation.
     The `dealloc` operation should not be called on memrefs which alias an
     alloc'd memref (e.g. memrefs returned by `view` operations).
 
     Example:
 
     ```mlir
     %0 = alloc() : memref<8x64xf32, (d0, d1) -> (d0, d1), 1>
     dealloc %0 : memref<8x64xf32, (d0, d1) -> (d0, d1), 1>
     ```
   }];
 
-  let arguments = (ins AnyMemRef:$memref);
+  let arguments = (ins Arg<AnyMemRef, "", [MemFree]>:$memref);
 
   let hasCanonicalizer = 1;
   let hasFolder = 1;
   let assemblyFormat = "$memref attr-dict `:` type($memref)";
 }
 
 //===----------------------------------------------------------------------===//
 // DimOp