This is an archive of the discontinued LLVM Phabricator instance.

[libc][NFC] Cleanup dependencies in src/signal and test/src/signal.
ClosedPublic

Authored by sivachandra on Apr 21 2020, 1:18 PM.

Diff Detail

Event Timeline

sivachandra created this revision.Apr 21 2020, 1:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2020, 1:18 PM

There are other targets also which can be simplified. But, I am seeking feedback on the pattern I have followed in the signal directory as @abrachet setup the targets in this directory. If it looks good, I can extend it to other places as well.

abrachet accepted this revision.Apr 21 2020, 2:40 PM

LG

libc/test/src/signal/CMakeLists.txt
20–24

Nit: we could put raise above sigaction like we do everywhere else.

Not for this patch, but It would be nice if all of our dependencies were alphabetical. I've not done a good job of that. I will look into if there is a programmatic way to have them ordered nicely.

35

Probably I should remove the line https://github.com/llvm/llvm-project/blob/master/libc/test/src/signal/sigprocmask_test.cpp#L36 and remove this too. But maybe not appropriate for this patch.

63
This revision is now accepted and ready to land.Apr 21 2020, 2:40 PM
sivachandra marked 3 inline comments as done.Apr 21 2020, 10:28 PM
sivachandra added inline comments.
libc/test/src/signal/CMakeLists.txt
20–24

Fixed this in the commit.

If you end up with something like a Python script which can formally parse our CMakeLists.txt files, that will be awesome and we can put it in say utils/buildutils.

35

Ack.

63

Ack.

This revision was automatically updated to reflect the committed changes.