Page MenuHomePhabricator

Use checks_on_target for libunwind and libc++abi tests on cross-builders
ClosedPublic

Authored by broadwaylamb on Apr 20 2020, 3:59 AM.

Details

Summary

This allows specifying lit arguments on a per-target basis.

Right now the libc++ check displays the number of passes/failures/unsupported tests, while libunwind and libc++abi checks don't:

We need to pass the -v -vv flags so that the output contains the status of each test. We can't do it through CMake using the LLVM_LIT_FLAGS variable (like we do it now), because the flags specified in that variable are only propagated to llvm, clang and lld tests, but not the runtimes tests (and this is very unlikely to change), so we specify them by invoking llvm-lit directly.

Diff Detail

Event Timeline

broadwaylamb created this revision.Apr 20 2020, 3:59 AM
broadwaylamb edited the summary of this revision. (Show Details)Apr 20 2020, 10:15 AM
andreil99 accepted this revision.Apr 20 2020, 7:27 PM

Thanks, Sergej!

This revision is now accepted and ready to land.Apr 20 2020, 7:27 PM