This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget][nfc][nvptx] Less verbose debug build
Needs RevisionPublic

Authored by JonChesterfield on Apr 16 2020, 3:12 PM.

Details

Summary

[libomptarget][nfc][nvptx] Less verbose debug build

When compiling with LIBOMPTARGET_NVPTX_DEBUG, verbose ptxas
provides approximately 300 instances of diagnostics of the form:
ptxas info : Function properties for some_function
x bytes stack frame, y bytes spill stores, z bytes spill loads

While interesting if tuning the performance of the runtime, it doesn't seem
worth having this in the build output by default.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2020, 3:12 PM

I guess it's a reasonable thought to disable such verbose output by default, but I can also see why these diagnostics could be useful l in some cases. Can we introduce a CMake variable to toggle --ptxas-options=-v on and off? (off by default)

jdoerfert accepted this revision.Apr 21 2020, 9:38 AM
This comment was removed by jdoerfert.
This revision is now accepted and ready to land.Apr 21 2020, 9:38 AM
jdoerfert requested changes to this revision.Apr 21 2020, 9:39 AM

I did not see @grokos comment, I let him do the review.

This revision now requires changes to proceed.Apr 21 2020, 9:39 AM