This is an archive of the discontinued LLVM Phabricator instance.

Enable finding bitcode in wasm objects
ClosedPublic

Authored by alexcrichton on Apr 15 2020, 6:20 AM.

Details

Summary

This commit fixes using functions in IRObjectFile to load bitcode from
wasm objects by recognizing the file magic for wasm and also inheriting
the default implementation of classifying sections as bitcode.

Diff Detail

Event Timeline

alexcrichton created this revision.Apr 15 2020, 6:20 AM

Oh dear sorry I'm still quite green on submitting patches to LLVM, so I'm not actually entirely sure what the build failure here means. Is that a transient CI issue or something that I need to address? (searching around for "No valid crumb was included in the request" doesn't seem to turn up much...)

sbc100 accepted this revision.Apr 15 2020, 10:49 AM

If you've tested locally I think that fine, I don't see any actionable information in that harbormaster error.

This revision is now accepted and ready to land.Apr 15 2020, 10:49 AM

Ok cool, thanks! I did test this out locally and it worked for use case, so on that front should be good to go!

I don't think I have commit access to LLVM though, would it be ok if you committed this for me?

This revision was automatically updated to reflect the committed changes.