This is an archive of the discontinued LLVM Phabricator instance.

Differential D77901

[SVE] Remove calls to getBitWidth from x86
ClosedPublic

Authored by ctetreau on Apr 10 2020, 1:41 PM.

Details

Reviewers
efriedma
RKSimon
sdesmalen
Commits
rG85247c1e898f: [SVE] Remove calls to getBitWidth from x86

Diff Detail

Event Timeline

ctetreau created this revision.Apr 10 2020, 1:41 PM
Herald added a reviewer: efriedma. · View Herald TranscriptApr 10 2020, 1:41 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, psnobl, rkruppe and 2 others. · View Herald Transcript
ctetreau added a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 10 2020, 2:03 PM
ctetreau added a child revision: D77833: [SVE] Remove VectorType::getBitWidth().Apr 10 2020, 2:05 PM
Harbormaster completed remote builds in B52729: Diff 256652.Apr 10 2020, 2:32 PM
ctetreau added reviewers: RKSimon, sdesmalen.Apr 13 2020, 1:09 PM
ctetreau removed a parent revision: D77587: [SVE] Add new VectorType subclasses.Apr 13 2020, 4:56 PM
ctetreau updated this revision to Diff 257161.Apr 13 2020, 5:01 PM

rebase

Harbormaster failed remote builds in B53039: Diff 257161!Apr 13 2020, 6:05 PM
RKSimon accepted this revision.Apr 15 2020, 10:10 AM

LGTM

This revision is now accepted and ready to land.Apr 15 2020, 10:10 AM
Closed by commit rG85247c1e898f: [SVE] Remove calls to getBitWidth from x86 (authored by ctetreau). · Explain WhyApr 15 2020, 4:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
2 lines

Diff 257884

llvm/lib/Target/X86/X86ISelLowering.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,196 Lines • ▼ Show 20 Lines
} }
/// Helper for getByValTypeAlignment to determine /// Helper for getByValTypeAlignment to determine
/// the desired ByVal argument alignment. /// the desired ByVal argument alignment.
static void getMaxByValAlign(Type *Ty, unsigned &MaxAlign) { static void getMaxByValAlign(Type *Ty, unsigned &MaxAlign) {
if (MaxAlign == 16) if (MaxAlign == 16)
return; return;
if (VectorType *VTy = dyn_cast<VectorType>(Ty)) { if (VectorType *VTy = dyn_cast<VectorType>(Ty)) {
if (VTy->getBitWidth() == 128) if (VTy->getPrimitiveSizeInBits().getFixedSize() == 128)
MaxAlign = 16; MaxAlign = 16;
} else if (ArrayType *ATy = dyn_cast<ArrayType>(Ty)) { } else if (ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
unsigned EltAlign = 0; unsigned EltAlign = 0;
getMaxByValAlign(ATy->getElementType(), EltAlign); getMaxByValAlign(ATy->getElementType(), EltAlign);
if (EltAlign > MaxAlign) if (EltAlign > MaxAlign)
MaxAlign = EltAlign; MaxAlign = EltAlign;
} else if (StructType *STy = dyn_cast<StructType>(Ty)) { } else if (StructType *STy = dyn_cast<StructType>(Ty)) {
for (auto *EltTy : STy->elements()) { for (auto *EltTy : STy->elements()) {
▲ Show 20 Lines • Show All 46,670 Lines • Show Last 20 Lines