Page MenuHomePhabricator

[AMDGPU] Moving SI_RETURN_TO_EPILOG handling out of SIInsertSkips.
ClosedPublic

Authored by cdevadas on Apr 6 2020, 5:55 AM.

Details

Summary

For now, moving it to SIPreEmitPeephole.
Should find a right place to have this code.

Diff Detail

Event Timeline

cdevadas created this revision.Apr 6 2020, 5:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2020, 5:55 AM
arsenm added a comment.Apr 6 2020, 6:46 AM

I would expect there to be a test change? Did we not have a MIR test of this before?

llvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp
246

Should elaborate that this is not an optimization

What's the status of this?

cdevadas updated this revision to Diff 271633.Jun 18 2020, 3:08 AM
cdevadas edited the summary of this revision. (Show Details)

Rebase + added lit test

This revision is now accepted and ready to land.Jun 29 2020, 5:49 AM
This revision was automatically updated to reflect the committed changes.