This is an archive of the discontinued LLVM Phabricator instance.

Differential D77084

[lld][WebAssembly] Add test for --export of empty string
ClosedPublic

Authored by sbc100 on Mar 30 2020, 1:04 PM.

Details

Reviewers
azakai
sunfish
Commits
rG9225ff62789e: [lld][WebAssembly] Add test for --export of empty string
Summary

The actual bug was fixed in https://reviews.llvm.org/D74589

Diff Detail

Event Timeline

sbc100 created this revision.Mar 30 2020, 1:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2020, 1:04 PM
Herald added subscribers: llvm-commits, sunfish, aheejin and 2 others. · View Herald Transcript
sbc100 added a reviewer: azakai.Mar 30 2020, 1:04 PM
Harbormaster completed remote builds in B51007: Diff 253673.Mar 30 2020, 2:11 PM
sbc100 added a comment.Apr 10 2020, 4:51 PM

ping

sunfish accepted this revision.Apr 11 2020, 6:37 AM
This revision is now accepted and ready to land.Apr 11 2020, 6:37 AM
Closed by commit rG9225ff62789e: [lld][WebAssembly] Add test for --export of empty string (authored by sbc100). · Explain WhyApr 11 2020, 6:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
test/
wasm/
4 lines

Diff 256812

lld/test/wasm/export-empty.test

  • This file was added.
RUN: llc -filetype=obj %p/Inputs/start.ll -o %t.o
RUN: not wasm-ld --export "" %t.o -o %t.wasm 2>&1 | FileCheck --match-full-lines %s
CHECK: wasm-ld: error: symbol exported via --export not found: